New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(tsql): improve support for transaction statements #1907

Merged

georgesittas merged 20 commits into tobymao:main from dmoore247:transactions

Jul 11, 2023

Contributor

dmoore247 commented Jul 10, 2023

Enrich syntax parsing for BEGIN, COMMIT and ROLLBACK Transactions.

dmoore247 and others added 11 commits

July 6, 2023 15:48


          Modify tsql BEGIN TRANSACTION to be BEGIN TRANSACTION

c5ab2ff


          enhance tsql transaction mapping and stored proc begin... interim commit

c6ea5ce


          Make tsql BEGIN TRANSACTION parse in all it's flavors

474ea39


          Enrich TSQL begin transaction, commit transaction, rollback transacti…

dae6818

…on per tsql specifications


          undo fat fingering of _parse_convert

95d14b1


          deal with merge conflict on return_sql

c9e6ad2


          re-write BEGIN TRANSACTION

6ba0901


          Merge branch 'main' into transactions

a39ef65


          remove extraineous CONVERT unit test

a097ea7


          Merge branch 'transactions' of https://github.com/dmoore247/sqlglot i…

99b977b

…nto transactions


          run make check

ca3d6d2

tobymao reviewed

View reviewed changes

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

tobymao reviewed

View reviewed changes

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

tobymao reviewed

View reviewed changes

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

tobymao reviewed

View reviewed changes

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

tobymao reviewed

View reviewed changes

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

tobymao reviewed

View reviewed changes

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

tobymao reviewed

View reviewed changes

sqlglot/expressions.py Outdated Show resolved Hide resolved

tobymao reviewed

View reviewed changes

sqlglot/parser.py Outdated Show resolved Hide resolved

georgesittas reviewed

View reviewed changes

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

sqlglot/expressions.py Outdated Show resolved Hide resolved

tests/dialects/test_tsql.py Outdated Show resolved Hide resolved

tests/dialects/test_tsql.py Outdated Show resolved Hide resolved

tests/dialects/test_tsql.py Outdated Show resolved Hide resolved

tests/dialects/test_tsql.py Outdated Show resolved Hide resolved

tests/dialects/test_tsql.py Show resolved Hide resolved

Collaborator

georgesittas commented Jul 11, 2023

@dmoore247 let us know when you push the changes so we can re-review. Thanks for the quick iterations here.

dmoore247 marked this pull request as draft

July 11, 2023 18:56

dmoore247 added 4 commits

July 11, 2023 14:58


          PR review comments update, still work in progress

9856cee


          Remove BEGIN TRANSACTION keyword

cb07d9c


          Remove transaction parameter

4b929a0


          Remove modes from Commit interface

064125a

georgesittas reviewed

View reviewed changes

Collaborator

georgesittas left a comment

Ok I think there are a few comments left and this should be good to go.

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

dmoore247 added 3 commits

July 11, 2023 18:51


          move CREATE PROCEDURE keyword tests, remove TokenType.BEGIN from tsql…

bcc5263

… KEYWORDS list, however change signature of _parse_transaction to reflect returning a Begin expression


          Remove redundant tokens in tsql KEYWORDS, remove description from met…

3fcd22a

…hod comments


          tighten up code for _parse_transaction per feedback

georgesittas reviewed

View reviewed changes

sqlglot/dialects/tsql.py Show resolved Hide resolved

sqlglot/parser.py Outdated Show resolved Hide resolved

sqlglot/dialects/tsql.py Outdated Show resolved Hide resolved

georgesittas marked this pull request as ready for review

July 11, 2023 23:31

georgesittas changed the title ~~feat TSQL Transaction enhancement~~ Feat(tsql): improve support for transaction statements

dmoore247 added 2 commits

July 11, 2023 19:34


          Revert to matching on TokenType.BEGIN

e92e7eb


          Handle BEGIN as a command

19f9af9

Contributor Author

dmoore247 commented Jul 11, 2023

@georgesittas Looks like I resolved all the issues.

georgesittas merged commit e6b3a01 into tobymao:main

dmoore247 deleted the transactions branch

July 13, 2023 02:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet