fix!: Refactor exp.RegexpExtract (follow up 4326) #4341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @VaggelisD for finishing this up! Your "empty inbox" of prs and issues is inspiring! |
NickCrews
added a commit
to NickCrews/sqlglot
that referenced
this pull request
Nov 4, 2024
…RegexpExtract Followup to tobymao#4341
VaggelisD
added a commit
that referenced
this pull request
Nov 5, 2024
…RegexpExtract (#4343) * fix(duckdb): we ALWAYS need to render group if params is present for RegexpExtract Followup to #4341 * Update tests/dialects/test_duckdb.py --------- Co-authored-by: Vaggelis Danias <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #4326
groupon other dialects so we'd need to silence these warnings on each test