Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala3/kernel+core #1192

Merged
merged 51 commits into from
Jan 15, 2024
Merged

Scala3/kernel+core #1192

merged 51 commits into from
Jan 15, 2024

Conversation

Grryum
Copy link
Contributor

@Grryum Grryum commented Nov 20, 2023

Scala 3 is coming!

Here are modules already ported:

@Odomontois
Copy link
Member

Thank you very much for all of this colossal work.
The only thing that frightens me is the proposed implementation of Interop macros.
It clearly was done to be compatible with scala 2 definitions.
When I've implemented this I've missed some features of scala 3 inlines a lot, meaning I had to pass code line to the macro via structural type.
So I've had in mind that when that would be migrating to scala 3, we will rewrite the delegation implementation and "delegating" to instances would have scala-specificб but because of all that huge work, I hope we can do that in the folliwing PR.
So I have no options but to accept this PR, it feels like it's now or never


// For such cases old and classic `asInstanceOf` helps with extra casting.

val asInstanceOf = TypeRepr.of[AnyRef].typeSymbol.methodMember("asInstanceOf").head
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very unpleasant. But I suppose we can cope with it for now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup! @road21 tried to fix it and replaced with widen.
Hope now it is not so unpleasant :)

@Grryum Grryum force-pushed the scala3/kernel+core branch 2 times, most recently from 927a9a8 to 7e1b9f2 Compare November 22, 2023 22:55
@Grryum Grryum force-pushed the scala3/kernel+core branch 2 times, most recently from 2abd492 to 9ea59d3 Compare November 23, 2023 08:37
@Grryum
Copy link
Contributor Author

Grryum commented Nov 23, 2023

partially closes #1068

@Odomontois
Copy link
Member

What happened with doc generation?

@Odomontois Odomontois merged commit 2ebd463 into tofu-tf:master Jan 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants