Remove dependency on itertools
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Happy to merge this! Looks like I'll need to adjust CI a bit, however... |
jswrenn
force-pushed
the
remove-itertools
branch
from
16d4d3f
to
eb77300
Compare
|
@jswrenn Thanks, CI seems fixed now! |
26 tasks
|
Merged! Sorry for the delay; I needed to work out some kinks with CI. Is there any particular reason you wanted to remove itertools that I should be aware of? |
|
Thanks!
No special reason except to prevent dependency bloat. Got a warning from cargo deny about having duplicated itertools versions in the dependency tree, so initially came here just to bump itertools. But seeing that it was probably better to remove for now I went for that instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.