Remove wrong debug_assert in MatchedPath
#1585
Conversation
|
|
||
| let res = client.get("/foobar").send().await; | ||
| assert_eq!(res.status(), StatusCode::OK); | ||
| assert_eq!(res.text().await, "/*path/foobar"); |
There was a problem hiding this comment.
I'm not really sure what the matched path logically should be. Feels weird saying it is /*path/foobar since the request is just /foobar, so where does /*path come from?
However it kinda matches the way the router is setup 🤔
Regardless it shouldn't panic 😅
There was a problem hiding this comment.
In general I think a more correct router setup would be
async fn handler(req: Request<Body>) -> Response {
// could be cached in a `State`
let inner = Router::new().route(
"/foobar",
get(|matched_path: MatchedPath| async move { matched_path.as_str().to_owned() }),
);
// route based on `Host` or whatever else you need
Router::new().nest("/", inner).oneshot(req).await.unwrap()
}
// run it with
handler.into_make_service();
There was a problem hiding this comment.
generally like this
I'm using axum to make some framework like
pub struct App {
pub cfg: Arc<GatewayConfig>,
}
impl Application for App {
fn frame_cfg(&self) -> &ApiFrameConfig {
&self.cfg.frame_cfg
}
fn router(&self) -> Router {
Router::new()
.route("/", get(peace_api::responder::app_root))
.nest("/bancho", bancho::routers::bancho_client_routes())
}
fn apidocs(&self) -> utoipa::openapi::OpenApi {
GatewayApiDocs::openapi()
}
fn match_hostname(
&self,
Host(hostname): Host,
req: &Request<Body>,
) -> Option<Router> {
match hostname {
n if self.cfg.bancho_hostname.contains(&n) => {
Some(bancho::routers::bancho_client_routes())
},
_ => None,
}
}
}
#[tokio::main]
pub async fn main() {
let app = App::new(GatewayConfig::get());
http::serve(app).await;
}In general a reverse proxy can be used to direct the request to a certain path, which may be the router of a certain service
I would like to allow users to enable both general router and hostname based router. This may need to use /*path
possible to reuse some routers
|
Superseded by #1935 |
Fixes #1579