remove a seeming redundant code and possible clerical errors in examples/tls_rustls.rs

[xiuno]

when I run this example tls_rustls.rs cargo run --release is ok, then, curl -k http://127.0.0.1:3000/ got a error: response empty.

service info:

thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: hyper::Error(Parse(VersionH2))', src/main.rs:

I try to check the example code, found keyword b"h2", when I remove it, all is ok.

[davidpdrsn]

@programatik29 thoughts?

[programatik29]

@xiuno Make it https://localhost:3000/ since you are testing tls not plaintext http.
@davidpdrsn

[xiuno]

@xiuno Make it https://localhost:3000/ since you are testing tls not plaintext http.
@davidpdrsn

just I try to:
curl -k https://127.0.0.1:3000/abc
curl: (52) Empty reply from server

it works after remove b"h2".to_vec() yet.

[programatik29]

@xiuno Make it https://localhost:3000/ since you are testing tls not plaintext http.
@davidpdrsn

just I try to:
curl -k https://127.0.0.1:3000/abc
curl: (52) Empty reply from server

it works after remove b"h2".to_vec() yet.

Are you running the example with cargo run --example tls_rustls ?

[xiuno]

I try to run cargo run --example tls_rustls , it's ok!
after I create self sign certification, it works bad(curl -x https://127.0.0.1:3000/ enter loop waiting)! when I remove b"h2".to_vec() works
ok again!

make certification:

mkdir cert
cd cert
openssl genrsa -out root-key-pkcs1.key 2048
openssl pkcs8 -topk8 -inform PEM -in root-key-pkcs1.key -outform PEM
-nocrypt -out root-key-pkcs8.key
openssl req -new -out root-req.csr -key root-key-pkcs1.key -keyform PEM
-subj "/CN=localhost,AltName=DNS:localhost"
openssl x509 -req -extfile /usr/local/etc/openssl/openssl.cnf -extensions
v3_req  -in root-req.csr -out root-cert.cer -signkey root-key-pkcs1.key
-CAcreateserial -days 3650

change path of certification

let rustls_config = rustls_server_config(
        "cert/root-key-pkcs8.key",
        "cert/root-cert.cer",
);

server run:

cargo run --example tls_rustls

client request:

curl -x https://127.0.0.1:3000/

client enter loop waiting...

[programatik29]

There is a http2 hanging problem currently. That is what causes hanging. #108 introduces it. Test again in #139.

[programatik29]

There is a http2 hanging problem currently. That is what causes hanging. #108 introduces it. Test again in #139.

Also discovered that problem thanks to you @xiuno.

[programatik29]

h2 in alpn allows http2 protocol to be negotiated and used. Code is not redundant. Hanging bug is related to #191. This PR can be closed.

[davidpdrsn]

Alright. I'll close this then. @xiuno let us know if there is more to discuss 😊