CI: allow pin-project-lite
in public dependencies
#3020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
CI is currently failing because our public dependencies seem to include
pin-project-lite
. This seems to have started failing without any changes so it might be one of our previous public dependencies changed something which exposedpin-project-lite
and it is now visible also fromaxum
. But I didn't see any information about where the dependency is exposed or anything like that so this is just an assumption on my part.Solution
Allow the public dependency to unblock other PRs by fixing the CI.
It should be noted that if the assumption that we're exposing the project indirectly through another dependency, then it is also potentially exposed in the already released versions with latest transitive dependencies so this PR might be just blessing the current state.
Future Work
We should consider how we want to handle this in the future. The
cargo-public-api-crates
project doesn't seem to have any maintenance for some time. We can continue using it as a check that we didn't do something unintended and in cases like this we can change the expected set without fully understanding where a dependency comes from. Other options include someone stepping up to help maintain the project and discarding the check.