Remove Sync requirement from response bodies
#440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we learned [in Tonic] bodies don't need to be `Sync` because they can only be polled from one thread at a time. This changes axum's bodies to no longer require `Sync` and makes `BoxBody` an alias for `UnsyncBoxBody<Bytes, axum::Error>`. [in Tonic]: hyperium/tonic#117
LucioFranco
approved these changes
Nov 1, 2021
| ResBody: http_body::Body<Data = Bytes> + Send + Sync + 'static, | ||
| ResBody::Error: Into<BoxError> + Send + Sync + 'static, | ||
| ResBody: http_body::Body<Data = Bytes> + Send + 'static, | ||
| ResBody::Error: Into<BoxError>, |
This was referenced Nov 12, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we learned in Tonic bodies don't need to be
Syncbecause they canonly be polled from one thread at a time.
This changes axum's bodies to no longer require
Syncand makesBoxBodyan alias forUnsyncBoxBody<Bytes, axum::Error>.Also cleans up some body error trait bounds and a few misc other bounds
I noticed while cleaning this up.