Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make bytes_mut -> chunk_mut rename more easily discoverable #471

Merged
merged 4 commits into from
Jan 23, 2021
Merged

Make bytes_mut -> chunk_mut rename more easily discoverable #471

merged 4 commits into from
Jan 23, 2021

Conversation

Darksonn
Copy link
Contributor

Closes: #470

taiki-e
taiki-e approved these changes Jan 22, 2021
View reviewed changes
src/buf/buf_impl.rs Show resolved Hide resolved
@taiki-e
Copy link
Member

taiki-e commented Jan 22, 2021 •
edited
Loading

@Darksonn Could you update CI config to set RUSTDOCFLAGS="--cfg docsrs" environment variable?

bytes/.github/workflows/ci.yml

Lines 161 to 162 in 8daf43e

- name: Build documentation
run: cargo doc --no-deps --all-features

@taiki-e taiki-e merged commit e418280 into master Jan 23, 2021
@taiki-e taiki-e deleted the bytes_mut_chunk_doc_alias branch January 23, 2021 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.0.x renamed bytes to chunk and bytes_mut to chunk_mut
2 participants
@Darksonn @taiki-e