--retain-for default value not used

[abusch]

What crate(s) in this repo are involved in the problem?

tokio-console

What is the issue?

The help text for the --retain-for option suggests that the default value is 6 seconds, however this seems to be ignored. Done tasks seem to hang around forever in the UI.

Explicitly specifying a duration with --retain-for does work though.

How can the bug be reproduced?

Run tokio-console on a project, and observe "done" tasks staying around in the UI.

Logs, error output, etc

Output of tokio-console --help (notice the last line):

        --retain-for <RETAIN_FOR>
            How long to continue displaying completed tasks and dropped resources after they have
            been closed.

            This accepts either a duration, parsed as a combination of time spans (such as `5days
            2min 2s`), or `none` to disable removing completed tasks and dropped resources.

            Each time span is an integer number followed by a suffix. Supported suffixes are:

            * `nsec`, `ns` -- nanoseconds

            * `usec`, `us` -- microseconds

            * `msec`, `ms` -- milliseconds

            * `seconds`, `second`, `sec`, `s`

            * `minutes`, `minute`, `min`, `m`

            * `hours`, `hour`, `hr`, `h`

            * `days`, `day`, `d`

            * `weeks`, `week`, `w`

            * `months`, `month`, `M` -- defined as 30.44 days

            * `years`, `year`, `y` -- defined as 365.25 days

            [default: 6s]

Versions

❯ tokio-console --version
tokio-console 0.1.7

Possible solution

No response

Additional context

No response

Would you like to work on fixing this bug?

maybe

[abusch]

It seems the default value is set only in the Default impl for Config. As far as I can tell, this is only used when generating the default config file. If there is no config file, and you don't set the --retain-for, it's simply None in the Config object.