feat(config): default no_colors to false #344
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default
no_colors
setting to false.Why?
Before
Input below would produce no colors in tokio console, tho
palette
flag is explicitly passed, andno_colors
is not explicitly set totrue
.Input below also would produce no colors in tokio-console, tho
COLORTERM
is set totruecolor
, andno_colors
is not explicitly set totrue
.Also would produce no colors in tokio-console, tho
truecolor
is explicitly passed.So to enable colors you must explicitly set
no_colors
tofalse
, like so:tokio-console --truecolor --no-colors false http://127.0.0.1:6669
After PR
Colors are enabled.
Colors are enabled too.
Colors are disabled, because
no_colors
is explicitly passed, thoCOLORTERM
is set totruecolor
.Explanation
I think it's just not really obvious that you need to explicitly pass
--no-colors false
to enable colors, so it should default to false.