Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Debug impl optional for types #797

Merged
merged 20 commits into from
Sep 1, 2023

Conversation

audunska
Copy link
Contributor

See #795 for motivation. If this looks like an ok approach, I'll go ahead and add more documentation.

Where is a good place to put some tests for this behavior?

@audunska audunska changed the title Make Debug impl optional for Messages Make Debug impl optional for types Jan 13, 2023
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine approach, I would like to see a lot of tests added around the different combinations of debug impls and to also make sure the root level debug isn't a problem.

@AlJohri
Copy link

AlJohri commented Jul 25, 2023

Friendly bump on this @audunska -- would you be able to add some tests? This would be a really useful feature.

@audunska
Copy link
Contributor Author

audunska commented Aug 8, 2023

I didn't end up prioritizing it, but I can do it now :)

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a nice addition but I think we should add some tests since there is a lot of changes to the codegen.

@audunska
Copy link
Contributor Author

Ok, I've added some tests testing both the Message trait directly, and testing code generation. Anything else?

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests!

@LucioFranco LucioFranco merged commit f9a3cff into tokio-rs:master Sep 1, 2023
11 checks passed
@audunska audunska deleted the optional-debug branch September 2, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants