Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add docs.rs metadata to build with all features #1471

Merged
merged 1 commit into from
Aug 18, 2019
Merged

docs: add docs.rs metadata to build with all features #1471

merged 1 commit into from
Aug 18, 2019

Conversation

ipetkov
Copy link
Member

@ipetkov ipetkov commented Aug 18, 2019

Fixes #1467

@carllerche
Copy link
Member

I've also noticed that rustdoc is rendering fns incorrectly. For example TcpListener::accept renders as an impl Future return, yet we use async fn.

@ipetkov
Copy link
Member Author

ipetkov commented Aug 18, 2019

Seems like an issue with the nightly being used by docs.rs. At least as of rustc 1.39.0-nightly (2111aed0a 2019-08-17) the docs render properly

@ipetkov ipetkov merged commit 6d8d388 into tokio-rs:master Aug 18, 2019
@ipetkov ipetkov deleted the docs.rs branch August 18, 2019 18:11
@jonhoo jonhoo mentioned this pull request Mar 31, 2020
Closed
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carllerche carllerche carllerche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore: fix docs.rs documentation with feature flags
2 participants
@ipetkov @carllerche