Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timer: Rename sleep to delay_for, reexport from tokio #1518

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Aug 30, 2019

Motivation

Expose convenience function for Duration-based waiting

Solution

Renames sleep to delay_for for consistency and reexports from tokio::timer. Additionally, the docs are tweaked to mention "sleep" for better discoverability. We considered standardizing on the sleep name instead, but Sleep as a type makes for an awkward noun.

Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@carllerche carllerche merged commit d2bd6f5 into tokio-rs:master Aug 30, 2019
@Ralith Ralith deleted the timer-tweaks branch August 30, 2019 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants