timer: use our own AtomicU64 on targets with target_has_atomic less than 64 #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice if this was handled in the std crate. Is there a reason it’s not tackled there? |
This is difficult because |
|
Oh right, makes sense then.. |
taiki-e
commented
Sep 8, 2019
tokio-timer/src/atomic.rs
Outdated
|
|
||
| pub(crate) use self::imp::AtomicU64; | ||
|
|
||
| #[cfg(target_pointer_width = "64")] |
There was a problem hiding this comment.
This needs to be #[cfg(target_has_atomic = "64")], not #[cfg(target_pointer_width = "64")], but since feature(cfg_target_has_atomic) is not stable, will use an alternative.
taiki-e
commented
Sep 8, 2019
| displayName: Check source | ||
|
|
||
| - script: cargo check --tests --all --exclude tokio-tls --target ${{ parameters.target }} | ||
| displayName: Check tests | ||
| # - script: cross check --tests --all --exclude tokio-tls --target $(target) |
There was a problem hiding this comment.
This cannot be enabled because at least one dev-dependency does not support architectures other than x86_64.
taiki-e
commented
Sep 8, 2019
| @@ -1,27 +1,41 @@ | |||
| jobs: | |||
| - job: ${{ parameters.name }} | |||
| displayName: ${{ parameters.displayName }} | |||
| strategy: | |||
| matrix: | |||
There was a problem hiding this comment.
This matrix is roughly the same as what we use in bytes.
taiki-e
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #1421 (comment)
Solution
Reverts part of #1421.