Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Delay must_use #1714

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Make Delay must_use #1714

merged 1 commit into from
Oct 31, 2019

Conversation

sfackler
Copy link
Contributor

Closes #1711

@carllerche carllerche merged commit 630d313 into tokio-rs:master Oct 31, 2019
@carllerche
Copy link
Member

@taiki-e feel free to merge PRs you +1.

@taiki-e
Copy link
Member

taiki-e commented Oct 31, 2019

seems ci wasn't finished yet at the time I approved... (as mentioned in #1695 (comment), current ci take 50 minutes)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delay is not #[must_use]
3 participants
@sfackler @carllerche @taiki-e