Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time: Remove HandlePriv #1896

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

kleimkuhler
Copy link
Contributor

Motivation

#1800 removed the lazy binding of Delays to timers. With the removal of the
logic required for that, HandlePriv is no longer needed. This PR removes the
use of HandlePriv.

A TODO was also removed that would panic if when registering a new Delay
the current timer handle was full. That has been fixed to now immediately
transition that Delay to an error state that can be handled in a similar way
to other error states.

Signed-off-by: Kevin Leimkuhler [email protected]

Signed-off-by: Kevin Leimkuhler <[email protected]>
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kleimkuhler kleimkuhler merged commit dbcd1f9 into tokio-rs:master Dec 5, 2019
@kleimkuhler kleimkuhler deleted the kleimkuhler/timer-cleanup branch December 5, 2019 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants