Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsoundness in read_to_end #3428

Merged
merged 3 commits into from
Jan 14, 2021
Merged

Conversation

Darksonn
Copy link
Contributor

This is a companion of #3426 that contains just the unsoundness fix so we can release it in a patch release.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-io Module: tokio/io labels Jan 14, 2021
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@@ -1,8 +1,8 @@
on:
push:
branches: ["master"]
branches: ["tokio-1.0.x"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep master as we will eventually merge into master. Also, we should be able to do a glob: "tokio-*.x".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@carllerche carllerche merged commit ad8fb41 into tokio-1.0.x Jan 14, 2021
@carllerche carllerche deleted the read_to_end_soundness branch January 14, 2021 23:09
carllerche pushed a commit that referenced this pull request Jan 15, 2021
@Darksonn Darksonn mentioned this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-io Module: tokio/io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants