Fix docs.rs build with cfg(docsrs) #3561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For crates which set `rustc-args = ["--cfg", "docsrs"] ` in `[package.metadata.docs.rs]`, tokio-stream fails to build on docs.rs with ``` [INFO] [stderr] Compiling tokio-stream v0.1.3 [INFO] [stderr] error[E0636]: the feature `doc_cfg` has already been declared [INFO] [stderr] --> /opt/rustwide/cargo-home/registry/src/github.com-1ecc6299db9ec823/tokio-stream-0.1.3/src/lib.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | #![cfg_attr(docsrs, feature(doc_cfg))] [INFO] [stderr] | ^^^^^^^ ``` The first occurence of the same `cfg_attr` command is on https://github.com/tokio-rs/tokio/blob/master/tokio-stream/src/lib.rs#L17
|
Do we not test with this flag in CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For crates which set
rustc-args = ["--cfg", "docsrs"]in[package.metadata.docs.rs], tokio-stream fails to build on docs.rs withSolution
Remove duplicate
cfg_attrlineThe first occurence is on https://github.com/tokio-rs/tokio/blob/master/tokio-stream/src/lib.rs#L17