Make windows docs for signal module show up on unix builds #3770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
T-docs
|
Oh, I didn't notice that #3768 was a PR. I thought it was an issue 😅 |
I see. I guess it's good that we both got a bit of experience doing this! I'll check this out and see if something can be done differently in the other PR at least. |
carllerche
approved these changes
Aug 2, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves most of the windows implementation for signal into a new
tokio/src/signal/windows/os_impl.rsfile, leaving thetokio/src/signal/windows.rsfile with only definitions of the public types. This makes the documentation show up when building on unix.