Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io: fix take when using evil reader (backport #4428) #4434

Merged
merged 4 commits into from
Jan 30, 2022

Conversation

carllerche
Copy link
Member

Backports #4428 into 1.8.x

@carllerche carllerche added A-tokio Area: The main tokio crate I-unsound 💥 A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness M-io Module: tokio/io labels Jan 27, 2022
@carllerche
Copy link
Member Author

The CircleCI build will fail due to missing configuration. It shouldn't block merging.

@carllerche carllerche force-pushed the merge-4428 branch 2 times, most recently from d462643 to e5121a2 Compare January 28, 2022 01:26
@Darksonn
Copy link
Contributor

This needs to include #4437.

@carllerche
Copy link
Member Author

@Darksonn thanks, I'll pull it in once I wrangle CI.

@carllerche
Copy link
Member Author

@Darksonn Ok, I backported the fix as well.

carllerche added a commit that referenced this pull request Jan 30, 2022
When backporting patches to LTS branches, we often run into CI failures due to
changes in rust. Newer rust versions add more lints, which break CI. We really
don't want to also have to backport patches that fix CI, so instead, LTS branches
should pin the stable rust version in CI (e.g. #4434).

This PR restructures the CI config files to make it a bit easier to set a specific rust
version in CI.
@carllerche
Copy link
Member Author

Reordering commit before merge.

@carllerche carllerche merged commit 12606d6 into tokio-1.8.x Jan 30, 2022
@carllerche carllerche deleted the merge-4428 branch January 30, 2022 19:45
carllerche added a commit that referenced this pull request Jan 30, 2022
When backporting patches to LTS branches, we often run into CI failures due to
changes in rust. Newer rust versions add more lints, which break CI. We really
don't want to also have to backport patches that fix CI, so instead, LTS branches
should pin the stable rust version in CI (e.g. #4434).

This PR restructures the CI config files to make it a bit easier to set a specific rust
version in CI.
carllerche added a commit that referenced this pull request Jan 30, 2022
When backporting patches to LTS branches, we often run into CI failures due to
changes in rust. Newer rust versions add more lints, which break CI. We really
don't want to also have to backport patches that fix CI, so instead, LTS branches
should pin the stable rust version in CI (e.g. #4434).

This PR restructures the CI config files to make it a bit easier to set a specific rust
version in CI.
carllerche added a commit that referenced this pull request Jan 31, 2022
When backporting patches to LTS branches, we often run into CI failures due to
changes in rust. Newer rust versions add more lints, which break CI. We really
don't want to also have to backport patches that fix CI, so instead, LTS branches
should pin the stable rust version in CI (e.g. #4434).

This PR restructures the CI config files to make it a bit easier to set a specific rust
version in CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate I-unsound 💥 A soundness hole (worst kind of bug), see: https://en.wikipedia.org/wiki/Soundness M-io Module: tokio/io
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants