Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: fix missing doc(cfg(...)) attributes for JoinSet #4531

Merged
merged 1 commit into from
Feb 23, 2022

Commits on Feb 23, 2022

  1. task: fix missing doc(cfg(...)) attributes for JoinSet

    ## Motivation
    
    The `JoinSet` type is currently missing the `tokio_unstable` and
    `feature = "rt"` `doc(cfg(...))` attributes, making it erroneously
    appear to be available without the required feature and without unstable
    features enabled. This is incorrect.
    
    I believe this is because `doc(cfg(...))` on a re-export doesn't
    actually add the required cfgs to the type itself, and the
    `cfg_unstable!` is currently only guarding a re-export and module.
    
    ## Solution
    
    This PR fixes the missing attributes.
    hawkw committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    04871f8 View commit details
    Browse the repository at this point in the history