macros: fix span of body variable #5244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some quick testing seems to indicate that this retains the behavior for r-a 👍 (even if it didn't, we are currently trying to fix our token mapping which makes the r-a hack here obsolete ideally, no ETA though) |
Thomasdezeeuw
approved these changes
Nov 29, 2022
|
@taiki-e can you make another release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #5243
Solution
This is basically the same problem as dtolnay/async-trait#104 and dtolnay/async-trait#46, and can be fixed by assigning a consistent span to the same variable. See also dtolnay/async-trait#105 (comment). (The root cause is a compiler bug that overwrites spans of non-
:ttmetavariables during declarative macro expansion.)