Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update windows-sys 0.52 #6154

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Update windows-sys 0.52 #6154

merged 1 commit into from
Jul 23, 2024

Conversation

kennykerr
Copy link
Contributor

@kennykerr kennykerr commented Nov 17, 2023 •
edited
Loading

This is the first update to the windows-sys crate in 8 months. https://github.com/microsoft/windows-rs/releases/tag/0.52.0

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-net Module: tokio/net labels Nov 22, 2023
@Darksonn
Copy link
Contributor

Tokio will update when mio does.

@kennykerr
Copy link
Contributor Author

Looks like mio still has an older MSRV than tokio and windows-sys. tokio-rs/mio#1725

@Darksonn
Copy link
Contributor

Since the mio PR was closed, I'll close this for now.

At the latest, we can update in March when the old LTS is no longer supported.

@Darksonn Darksonn closed this Nov 25, 2023
@NobodyXu NobodyXu mentioned this pull request Dec 5, 2023
Closed
@flisky flisky mentioned this pull request Jan 23, 2024
Open
@westy92
Copy link

westy92 commented May 5, 2024

I opened a PR to unblock this.
tokio-rs/mio#1783

@atouchet atouchet mentioned this pull request Jul 23, 2024
Merged
@Thomasdezeeuw
Copy link
Contributor

After #6635 is merged I think this can be reopened.

@Darksonn Darksonn reopened this Jul 23, 2024
@Darksonn
Copy link
Contributor

I reopened and rebased this. Let's see if CI passes.

Darksonn
Darksonn approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 51b03f0 into tokio-rs:master Jul 23, 2024
78 checks passed
@Darksonn Darksonn mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-net Module: tokio/net
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kennykerr @Darksonn @westy92 @Thomasdezeeuw