-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add is_closed
, is_empty
and len
to mpsc::Receiver
and mpsc::UnboundedReceiver
#6348
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
48587f8
Add `is_closed` to `mpsc::Receiver` and `mpsc::UnboundedReceiver`
balliegojr be9bbeb
fixes documentation links
balliegojr ccecf35
splits is_closed tests into multiple smaller tests
balliegojr c1c870b
add is_closed tests for unbounded channel
balliegojr e655f9e
Add permit test for Receiver is_closed function
balliegojr 2d964a2
fix wrong permit comments in Receiver is_closed tests
balliegojr 816aea7
move empty channel check into is_empty function
balliegojr 8a3851a
remove mut requirement from the is_empty function
balliegojr ab5278b
add len function to bounded and unbounded receivers
balliegojr 8d505dd
reduces the unsafe scope in the len function
balliegojr 1e50d9f
fixes the is_empty function
balliegojr d5b1b1f
Merge branch 'master' into receiver-is-closed
balliegojr fbd1794
refactor mpsc list len and is_empty functions
balliegojr 6537a80
add missing rx len test scenarios
balliegojr ba1ccb3
Merge branch 'master' into receiver-is-closed
balliegojr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have a test for whether the length is correct in all of the following cases?
Receiver::close
has been called.Receiver::close
has not been called.Receiver::close
has been called before the last sender dropped.Receiver::close
has been called after the last sender dropped.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the scenarios were missing, but I have added them now.