Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: reorder const_new before new_with #6392

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

Darksonn
Copy link
Contributor

This reorders the functions on OnceCell so that they appear in this order: new, const_new, new_with, const_new_with. Changing the order improves the documentation, as they appear in the same order there.

I know that the diff doesn't show it that way, but I really did just reorder the methods.

@Darksonn Darksonn added T-docs Topic: documentation A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Mar 12, 2024
@github-actions github-actions bot added the R-loom-sync Run loom sync tests on this PR label Mar 12, 2024
Copy link
Member

@tobz tobz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Darksonn
Copy link
Contributor Author

CI failure is hyperium/hyper#3599.

@Darksonn Darksonn enabled auto-merge (squash) March 12, 2024 14:17
@Darksonn Darksonn merged commit ea1cfbd into tokio-rs:master Mar 12, 2024
75 checks passed
@Darksonn Darksonn deleted the alice/reorder-const-new branch March 12, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync R-loom-sync Run loom sync tests on this PR T-docs Topic: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants