Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tokio(metrics): fix blocking_threads count #6551

Merged
merged 6 commits into from
May 25, 2024
Merged

tokio(metrics): fix blocking_threads count #6551

merged 6 commits into from
May 25, 2024

Conversation

conradludgate
Copy link
Contributor

Motivation

Fixes #6550

Solution

For the multithreaded scheduler handles, subtract the number of worker threads from the blocking threads count.

@github-actions github-actions bot added R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR labels May 10, 2024
@mox692 mox692 added the M-metrics Module: tokio/runtime/metrics label May 11, 2024
@Darksonn Darksonn added the A-tokio Area: The main tokio crate label May 11, 2024
Darksonn
Darksonn approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@conradludgate @Darksonn
use saturating sub
5526963 
Co-authored-by: Alice Ryhl <[email protected]>
Darksonn
Darksonn approved these changes May 25, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@Darksonn Darksonn enabled auto-merge (squash) May 25, 2024 20:12
@Darksonn Darksonn merged commit 2890d0c into tokio-rs:master May 25, 2024
83 checks passed
@Darksonn Darksonn mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-metrics Module: tokio/runtime/metrics R-loom-multi-thread Run loom multi-thread tests on this PR R-loom-multi-thread-alt Run loom multi-thread alt tests on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

runtime metrics blocking threads miscount
3 participants
@conradludgate @Darksonn @mox692