time: remove the true_when field in TimerShared. #6563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
R-loom-time-driver
wathenjiang
force-pushed
the
true_when_remove
branch
from
e44303e
to
b76a36e
Compare
…ffect, we should remove the true_when field. It will be a win in memory type size, which reduces the size of TimerShared from 72 bytes to 64 bytes. It should be beneficial for memory cache.
wathenjiang
force-pushed
the
true_when_remove
branch
from
b76a36e
to
067bc61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
true_whenfield in theTimerSharedstruct actually has no effect, we should remove thetrue_whenfield.It will be a win in memory type size, which reduces the size of
TimerSharedfrom 72 bytes to 64 bytes. It should be beneficial for memory cache.