Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: add create_new function to File #6573

Merged
merged 1 commit into from
May 22, 2024
Merged

fs: add create_new function to File #6573

merged 1 commit into from
May 22, 2024

Conversation

maminrayej
Copy link
Member

@maminrayej maminrayej commented May 19, 2024 •
edited
Loading

This PR adds support for the recently stabilized create_new function to File by configuring OpenOptions with appropriate flags. The implementation should forward the call to std once MSRV catches up to 1.77.

Resolves #6557.

@maminrayej maminrayej added A-tokio Area: The main tokio crate M-fs Module: tokio/fs labels May 19, 2024
@maminrayej maminrayej requested a review from Darksonn May 21, 2024 08:06
Darksonn
Darksonn approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Darksonn Darksonn merged commit 0b651c0 into tokio-rs:master May 22, 2024
77 checks passed
@Darksonn Darksonn mentioned this pull request May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-fs Module: tokio/fs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add File::create_new convenience c'tor
2 participants
@maminrayej @Darksonn