chore: increase MSRV to 1.70 #6645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the next debian stable will have 1.75. I don't know when it will be released though. I'm fine with whatever I guess, but we probably need to keep an LTS that works on debian stable working. |
Thomasdezeeuw
approved these changes
Jun 21, 2024
There was a problem hiding this comment.
This would very much help with the update to Mio v1 (#6635).
|
@carllerche It looks like it will be ~1 year until debian stable will start using 1.75.0. I don't think we should wait for that. We can make an LTS release now, then bump the MSRV afterwards? |
|
I’m fine with it. |
Darksonn
force-pushed
the
alice/msrv-1.70
branch
from
3460843
to
404a932
Compare
This was referenced Jul 22, 2024
Merged
3 tasks
notmandatory
added a commit
to bitcoindevkit/bdk
that referenced
this pull request
Jul 27, 2024
28d7530 ci: pin tokio to 1.38.1 to support MSRV 1.63 (Steve Myers) Pull request description: ### Description The latest tokio minor version update from 1.38.1 to 1.39.1 changed it's MSRV from 1.63.0 to 1.70.0, breaking our CI MSRV 1.63 testing. This PR pins `tokio` back to 1.38.1 for our CI MSRV testing. ### Notes to the reviewers tokio-rs/tokio#6645 https://crates.io/crates/tokio/versions ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing ACKs for top commit: LagginTimes: ACK 28d7530 ValuedMammal: ACK 28d7530 oleonardolima: ACK 28d7530 Tree-SHA512: 9eef750422cb8c3faa15771438e790afae44362d7c77e1d36cf70816ac7dabdd2e408e14502836ec86f845a2f1fe82905000c681fb6b4e873b036a41a280abd9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mio v1 was recently released, and it requires an MSRV of 1.70.0 for various changes that mio is using to get rid of its
SocketAddrtype and instead use the std version. This PR proposes to bump the MSRV of Tokio to 1.70.The main disadvantage is that debian stable is still at rustc 1.63.
Refs: #6635