io: implement AsyncSeek for Empty
#6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wathenjiang
reviewed
Jun 29, 2024
This adds more tests seeking with other kinds of `SeekFrom`. It follows the same structure as used in rust-lang/rust@f1cd179. See <tokio-rs#6663 (comment)>.
This follows the style of the other trait implementations of `Empty`. See <tokio-rs#6663 (comment)>.
This was referenced Jul 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While porting a test from
std:iototokio::io, I discoveredAsyncSeekis not implemented fortokio::io::Empty. This was unexpected, asstd::io::Seekwas implemented forstd::io::Emptyin Rust 1.51.0 (2021-03-25).Solution
This implementation mimics the behavior of the
Seekimplementation forstd::io::Empty.