Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macros: accept IntoFuture args for macros #6710

Merged
merged 3 commits into from
Jul 23, 2024
Merged

macros: accept IntoFuture args for macros #6710

merged 3 commits into from
Jul 23, 2024

Conversation

Darksonn
Copy link
Contributor

Closes: #6442

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-macros Module: macros in the main Tokio crate labels Jul 22, 2024
hds
hds approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Darksonn Darksonn enabled auto-merge (squash) July 23, 2024 12:43
@Darksonn Darksonn merged commit dd1d371 into master Jul 23, 2024
77 checks passed
@Darksonn Darksonn deleted the alice/join-select-into-future branch July 23, 2024 12:52
This was referenced Jul 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hds hds hds approved these changes

@conradludgate conradludgate conradludgate approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate M-macros Module: macros in the main Tokio crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

join and select macros should use IntoFuture
3 participants
@Darksonn @hds @conradludgate