Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix a symbol issue #6852

Merged
merged 1 commit into from
Sep 21, 2024
Merged

doc: Fix a symbol issue #6852

merged 1 commit into from
Sep 21, 2024

Conversation

vxzyfx
Copy link
Contributor

@vxzyfx vxzyfx commented Sep 17, 2024

Motivation

There is a punctuation error.

Solution

Change “socket hijacking” to "socket hijacking".

@jofas
Copy link
Contributor

jofas commented Sep 18, 2024

punctuation error

Just a nit, but the currently used quotation marks are known as smart quotes. Given that the comment is written in English prose, I wouldn't say they are erroneously used from a typographical perspective (albeit it's rare to see them actually typed out, given that they are non-trivial to type on a QWERTY keyboard). So the question of whether one should use smart quotes or non-smart quotes here boils down to a matter of taste—rather than right or wrong—IMO.

@vxzyfx
Copy link
Contributor Author

vxzyfx commented Sep 18, 2024

Thank you for your explanation.

@vxzyfx vxzyfx closed this Sep 18, 2024
@jofas
Copy link
Contributor

jofas commented Sep 18, 2024

My comment wasn't meant to be a rejection of your PR, I was just trying to contribute to the discussion. Whether your PR is an enhancement to the Tokio docs or not is not my decision to make. If you closed your PR just because of my comment, please reopen it and let the maintainers decide whether they want to merge this or not.

@vxzyfx vxzyfx reopened this Sep 18, 2024
@Darksonn Darksonn added T-docs Topic: documentation A-tokio Area: The main tokio crate M-net Module: tokio/net labels Sep 21, 2024
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♀️

@Darksonn Darksonn merged commit a302367 into tokio-rs:master Sep 21, 2024
158 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-net Module: tokio/net T-docs Topic: documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants