Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to opentelemetry 0.26 #169

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Upgrade to opentelemetry 0.26 #169

merged 2 commits into from
Oct 8, 2024

Conversation

ymgyt
Copy link
Contributor

@ymgyt ymgyt commented Oct 2, 2024

Motivation

Update opentelemetry depencencies to 0.26
https://github.com/open-telemetry/opentelemetry-rust/releases/tag/opentelemetry-0.26.0

Solution

Cargo.toml Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Collaborator

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Cargo.toml Show resolved Hide resolved
Cargo.toml Outdated
@@ -38,14 +38,17 @@ lazy_static = { version = "1.0.2", optional = true }
thiserror = { version = "1.0.31", optional = true }
smallvec = { version = "1.0", optional = true }

# https://github.com/open-telemetry/opentelemetry-rust/issues/2165
tonic = { version = "0.12.3", optional = true }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just wait for an upstream fix for this instead of working around it like this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@djc
As suggested in the review and issue, after executing cargo update, the error was resolved, and the line added to Cargo.toml:

tonic = { version = "0.12.3", optional = true }

became unnecessary.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not actually a fix, that's a workaround. Submitted a fix in open-telemetry/opentelemetry-rust#2168.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting the fix PR. I will update this PR once opentelemetry-proto version 0.26.1 is published.

Copy link

@lalitb lalitb Oct 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

opentelemetry-proto version 0.26.1 - This is released now.

src/layer.rs Outdated Show resolved Hide resolved
@djc
Copy link
Collaborator

djc commented Oct 8, 2024

Thanks! I'll get this published tomorrow.

@djc djc merged commit d817cf7 into tokio-rs:v0.1.x Oct 8, 2024
14 checks passed
@ymgyt ymgyt deleted the bump-otel branch October 9, 2024 05:14
@djc
Copy link
Collaborator

djc commented Oct 9, 2024

  • Published tracing-opentelemetry v0.27.0 at registry crates-io
  • [new tag] v0.27.0 -> v0.27.0
  • Release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants