-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to opentelemetry 0.26 #169
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Cargo.toml
Outdated
@@ -38,14 +38,17 @@ lazy_static = { version = "1.0.2", optional = true } | |||
thiserror = { version = "1.0.31", optional = true } | |||
smallvec = { version = "1.0", optional = true } | |||
|
|||
# https://github.com/open-telemetry/opentelemetry-rust/issues/2165 | |||
tonic = { version = "0.12.3", optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just wait for an upstream fix for this instead of working around it like this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's not actually a fix, that's a workaround. Submitted a fix in open-telemetry/opentelemetry-rust#2168.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for submitting the fix PR. I will update this PR once opentelemetry-proto version 0.26.1 is published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opentelemetry-proto version 0.26.1 - This is released now.
Thanks! I'll get this published tomorrow. |
|
Motivation
Update opentelemetry depencencies to 0.26
https://github.com/open-telemetry/opentelemetry-rust/releases/tag/opentelemetry-0.26.0
Solution
Key
AggregationSelector
trait andDefaultAggregationSelector
struct inopentelemetry-sdk
.