Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move off of opentelemetry in favor of separate crates. #48

Merged
merged 1 commit into from
Aug 12, 2023

Conversation

hdost
Copy link
Contributor

@hdost hdost commented Aug 10, 2023

Motivation

opentelemetry is going to be deprecated in favor of separated crates.

Solution

Use the opentelemetry_sdk crate for SDK calls instead of opentelemetry::sdk

@hdost hdost force-pushed the chore/migrate-to-separate-crates branch 2 times, most recently from 53142f4 to 616a71c Compare August 10, 2023 14:23
@hdost hdost marked this pull request as ready for review August 10, 2023 14:24
@hdost hdost requested a review from jtescher as a code owner August 10, 2023 14:24
Copy link
Contributor

@shaun-cox shaun-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

README.md Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@hdost hdost force-pushed the chore/migrate-to-separate-crates branch from 616a71c to bcf4c89 Compare August 11, 2023 03:28
`opentelemetry` is going to be deprecated in favor of separated crates.

open-telemetry/opentelemetry-rust#1186
Signed-off-by: Harold Dost <[email protected]>
@hdost hdost force-pushed the chore/migrate-to-separate-crates branch from bcf4c89 to 9fcdbaa Compare August 11, 2023 03:29
Copy link
Collaborator

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jtescher jtescher merged commit e914898 into tokio-rs:v0.1.x Aug 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants