Skip to content

Commit

Permalink
not-adding-modules-range-to-kcore-if-its-equal-to-vmcore-range-checkp…
Browse files Browse the repository at this point in the history
…atch-fixes

ERROR: space prohibited after that open parenthesis '('
torvalds#34: FILE: fs/proc/kcore.c:613:
+	if ( (MODULES_VADDR != VMALLOC_START) &&

ERROR: space prohibited before that close parenthesis ')'
torvalds#35: FILE: fs/proc/kcore.c:614:
+		(MODULES_END != VMALLOC_END) ) {

total: 2 errors, 0 warnings, 12 lines checked

./patches/not-adding-modules-range-to-kcore-if-its-equal-to-vmcore-range.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Baoquan He <[email protected]>
Cc: Paul Gortmaker <[email protected]>
Cc: Xishi Qiu <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
  • Loading branch information
akpm00 authored and sfrothwell committed Sep 26, 2014
1 parent ccfb878 commit 8d76d66
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/proc/kcore.c
Original file line number Diff line number Diff line change
Expand Up @@ -610,8 +610,7 @@ static void __init proc_kcore_text_init(void)
struct kcore_list kcore_modules;
static void __init add_modules_range(void)
{
if ( (MODULES_VADDR != VMALLOC_START) &&
(MODULES_END != VMALLOC_END) ) {
if (MODULES_VADDR != VMALLOC_START && MODULES_END != VMALLOC_END) {
kclist_add(&kcore_modules, (void *)MODULES_VADDR,
MODULES_END - MODULES_VADDR, KCORE_VMALLOC);
}
Expand Down

0 comments on commit 8d76d66

Please sign in to comment.