Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust 2018 and make encoding an optional feature #18

Closed
wants to merge 4 commits into from

Conversation

AlexApps99
Copy link

@AlexApps99 AlexApps99 commented Aug 20, 2020

Note: this PR supersedes #17 and #13

This PR:

  • Creates an optional (enabled by default) encoder feature
  • Updates the crate to Rust 2018
  • Removes rand from dependencies and into dev-dependencies
  • Fixes two typos made within the encoding section (including one Fix typo in VorbisQuality enum #13 failed to correct)
  • Updates all crates to most recent versions, vorbis-encoder is updated to Git master as crates.io version has outdated vorbis-sys

If needed, I can also apply cargo fmt before merging this PR.

This closes #16

@AlexApps99
Copy link
Author

@tomaka Are there any modifications I should apply to this PR?

@Hossein-Noroozpour
Copy link
Contributor

Hi it seems good. Thanks.

@AlexApps99
Copy link
Author

@tomaka apologies for pinging you again, but it's been a few months, wondering if you're ok with this PR?

@roderickvd
Copy link

roderickvd commented Mar 20, 2021

@tomaka are you still maintaining this repository?

@Hossein-Noroozpour could you update vorbis-encoder and even better, create a public repository for it? It currently is in dependency hell over vorbis-sys.

@AlexApps99 see further and partly conflicting work in #20, I propose that if this is no longer maintained then someone forks it. At this point this crate simply doesn't work on newer Rust versions.

@AlexApps99
Copy link
Author

I lost interest in this crate and wrote my own a while ago (don't think I uploaded it), feel free to fork if you want.
I'll close this PR in the mean time.

@AlexApps99 AlexApps99 closed this Mar 20, 2021
@roderickvd
Copy link

That's a pity. Regardless of your personal interest, your work is sound and should be merged.

@AlexApps99
Copy link
Author

If you wish to make a fork, feel free to use whatever is in this PR. Sadly these crates seem to be abandoned by tomaka

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link error: multiple packages link to native library
3 participants