Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configurable parallelism #64

Merged
merged 4 commits into from
Sep 15, 2023
Merged

configurable parallelism #64

merged 4 commits into from
Sep 15, 2023

Conversation

thomas-fred
Copy link
Collaborator

Configure parallelisation in split_edges_at_nodes via SNKIT_PROCESSES environment variable.

tomalrussell
tomalrussell requested changes Sep 11, 2023
View reviewed changes
Copy link
Owner

@tomalrussell tomalrussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of small suggestions - I think the logging config should be removed, the extra args is a makes-sense-to-me suggestion.

src/snkit/network.py Outdated Show resolved Hide resolved
src/snkit/network.py Outdated Show resolved Hide resolved
@tomalrussell tomalrussell merged commit 19f84f5 into main Sep 15, 2023
2 checks passed
@tomalrussell tomalrussell deleted the feature/configurable_parallelism branch November 13, 2023 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomalrussell tomalrussell Awaiting requested review from tomalrussell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomas-fred @tomalrussell