Fix GitLab OpenID instance as it breaks with latest pydantic #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest versions of Pydantic reject objects that are not created with their values aligned to their hints. This results in GitLab SSO breaking when trying to form the OpenID object, as the response from GitLab comes with an int for the 'id' field while OpenID pydantic model expects a string. Fix is simple and easy with just casting the field to string when creating the object in openid_from_response of GitlabSSO class.
|
@tomasvotava ^^ |
|
@chrisK824 hi! Thanks for the PR, I'll merge and release straight away. |
tomasvotava
approved these changes
Apr 1, 2024
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #143 +/- ##
=======================================
Coverage 94.27% 94.27%
=======================================
Files 19 19
Lines 437 437
=======================================
Hits 412 412
Misses 25 25
|
|
@chrisK824 released as 0.13.1 |
|
Awesome @tomasvotava ! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest versions of Pydantic reject objects that are not created with their values aligned to their hints.
This results in GitLab SSO breaking when trying to form the OpenID object, as the response from GitLab comes with an int for the 'id' field while OpenID pydantic model expects a string.
Fix is simple and easy with just casting the field to string when creating the object in openid_from_response of GitlabSSO class.