Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dfs support #12

Closed
wants to merge 1 commit into from
Closed

add dfs support #12

wants to merge 1 commit into from

Conversation

tcz001
Copy link

@tcz001 tcz001 commented Sep 4, 2019

#10

@tombuildsstuff
Copy link
Owner

hey @tcz001

Thanks for this PR.

Taking a look through whilst this PR looks like it's off to a good start, in this SDK we're slightly customizing the API endpoints to make them easier for consumers of the SDK to use, rather than mapping them 1:1 - for example by having multiple more granular endpoints to Create a Blob of different kinds rather than creating a generic "Create Blob" function which requires the user to determine which fields should be sent.

Ultimately this means that we're intentionally not auto-generating the code and adding acceptance tests as we go - for example in the case of a DataLakeStorage Gen2 FileSystem this means it'd be good to add a parser to read the properties back into a map[string]string, rather than making consumers of the SDK parse this themselves, since this'll contain a key-value pair of base64-encoded strings.

As such whilst I'd like to thank you for this contribution, I hope you don't mind but I'm going to open another PR which takes a slightly different approach but adds support for Data Lake Storage Gen2 FileSystems for API versions 2018-11-09 and 2018-03-28 - which should both fix #10 and mean that it's possible to unblock hashicorp/terraform-provider-azurerm#4244.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants