Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for DataLakeStorage Gen2 File Systems #14

Merged
merged 6 commits into from
Sep 13, 2019
Merged

Support for DataLakeStorage Gen2 File Systems #14

merged 6 commits into from
Sep 13, 2019

Conversation

tombuildsstuff
Copy link
Owner

This PR introduces support for DataLakeStorage Gen2 File Systems for API versions 2018-11-09 and 2018-03-28 (it's unavailable for `2017-07-29)

Fixes #10

Tests pass for API Version 2018-11-09:

$ envchain azurerm go test -v ./storage/2018-11-09/datalakestore/filesystems/
=== RUN   TestCreateHasNoTagsByDefault
2019/09/06 12:36:37 Testing if Service Principal / Client Certificate is applicable for Authentication..
2019/09/06 12:36:37 Testing if Service Principal / Client Secret is applicable for Authentication..
2019/09/06 12:36:37 Using Service Principal / Client Secret for Authentication
--- PASS: TestCreateHasNoTagsByDefault (77.76s)
    create_test.go:31: [DEBUG] Creating an empty File System..
    create_test.go:39: [DEBUG] Retrieving the Properties..
    create_test.go:49: [DEBUG] Deleting File System..
=== RUN   TestParseProperties
--- PASS: TestParseProperties (0.00s)
    helpers_test.go:62: [DEBUG] Test "no items"
    helpers_test.go:62: [DEBUG] Test "invalid item"
    helpers_test.go:62: [DEBUG] Test "single item"
    helpers_test.go:62: [DEBUG] Test "single-item-base64"
    helpers_test.go:62: [DEBUG] Test "single-item-base64-multipleequals"
    helpers_test.go:62: [DEBUG] Test "multiple-items-base64"
=== RUN   TestLifecycle
2019/09/06 12:37:55 Testing if Service Principal / Client Certificate is applicable for Authentication..
2019/09/06 12:37:55 Testing if Service Principal / Client Secret is applicable for Authentication..
2019/09/06 12:37:55 Using Service Principal / Client Secret for Authentication
--- PASS: TestLifecycle (75.87s)
    lifecycle_test.go:30: [DEBUG] Creating an empty File System..
    lifecycle_test.go:40: [DEBUG] Retrieving the Properties..
    lifecycle_test.go:53: [DEBUG] Updating the properties..
    lifecycle_test.go:64: [DEBUG] Re-Retrieving the Properties..
    lifecycle_test.go:79: [DEBUG] Deleting File System..
=== RUN   TestGetResourceID
--- PASS: TestGetResourceID (0.00s)
    resource_id_test.go:32: [DEBUG] Testing Environment "AzureChinaCloud"
    resource_id_test.go:32: [DEBUG] Testing Environment "AzureGermanCloud"
    resource_id_test.go:32: [DEBUG] Testing Environment "AzurePublicCloud"
    resource_id_test.go:32: [DEBUG] Testing Environment "AzureUSGovernmentCloud"
=== RUN   TestParseResourceID
--- PASS: TestParseResourceID (0.00s)
    resource_id_test.go:64: [DEBUG] Testing Environment "AzureChinaCloud"
    resource_id_test.go:64: [DEBUG] Testing Environment "AzureGermanCloud"
    resource_id_test.go:64: [DEBUG] Testing Environment "AzurePublicCloud"
    resource_id_test.go:64: [DEBUG] Testing Environment "AzureUSGovernmentCloud"
PASS
ok  	github.com/tombuildsstuff/giovanni/storage/2018-11-09/datalakestore/filesystems	153.647s

and API Version 2018-03-28:

$ envchain azurerm go test -v ./storage/2018-03-28/datalakestore/filesystems/
=== RUN   TestCreateHasNoTagsByDefault
2019/09/06 12:27:24 Testing if Service Principal / Client Certificate is applicable for Authentication..
2019/09/06 12:27:24 Testing if Service Principal / Client Secret is applicable for Authentication..
2019/09/06 12:27:24 Using Service Principal / Client Secret for Authentication
--- PASS: TestCreateHasNoTagsByDefault (76.71s)
    create_test.go:31: [DEBUG] Creating an empty File System..
    create_test.go:39: [DEBUG] Retrieving the Properties..
    create_test.go:49: [DEBUG] Deleting File System..
=== RUN   TestParseProperties
--- PASS: TestParseProperties (0.00s)
    helpers_test.go:62: [DEBUG] Test "no items"
    helpers_test.go:62: [DEBUG] Test "invalid item"
    helpers_test.go:62: [DEBUG] Test "single item"
    helpers_test.go:62: [DEBUG] Test "single-item-base64"
    helpers_test.go:62: [DEBUG] Test "single-item-base64-multipleequals"
    helpers_test.go:62: [DEBUG] Test "multiple-items-base64"
=== RUN   TestLifecycle
2019/09/06 12:28:41 Testing if Service Principal / Client Certificate is applicable for Authentication..
2019/09/06 12:28:41 Testing if Service Principal / Client Secret is applicable for Authentication..
2019/09/06 12:28:41 Using Service Principal / Client Secret for Authentication
--- PASS: TestLifecycle (77.40s)
    lifecycle_test.go:30: [DEBUG] Creating an empty File System..
    lifecycle_test.go:40: [DEBUG] Retrieving the Properties..
    lifecycle_test.go:53: [DEBUG] Updating the properties..
    lifecycle_test.go:64: [DEBUG] Re-Retrieving the Properties..
    lifecycle_test.go:79: [DEBUG] Deleting File System..
=== RUN   TestGetResourceID
--- PASS: TestGetResourceID (0.00s)
    resource_id_test.go:32: [DEBUG] Testing Environment "AzureChinaCloud"
    resource_id_test.go:32: [DEBUG] Testing Environment "AzureGermanCloud"
    resource_id_test.go:32: [DEBUG] Testing Environment "AzurePublicCloud"
    resource_id_test.go:32: [DEBUG] Testing Environment "AzureUSGovernmentCloud"
=== RUN   TestParseResourceID
--- PASS: TestParseResourceID (0.00s)
    resource_id_test.go:64: [DEBUG] Testing Environment "AzureChinaCloud"
    resource_id_test.go:64: [DEBUG] Testing Environment "AzureGermanCloud"
    resource_id_test.go:64: [DEBUG] Testing Environment "AzurePublicCloud"
    resource_id_test.go:64: [DEBUG] Testing Environment "AzureUSGovernmentCloud"
PASS
ok  	github.com/tombuildsstuff/giovanni/storage/2018-03-28/datalakestore/filesystems	154.132s

@tombuildsstuff tombuildsstuff mentioned this pull request Sep 6, 2019
Closed
@tombuildsstuff tombuildsstuff added this to the v0.5.0 milestone Sep 6, 2019
@tcz001
Copy link

tcz001 commented Sep 13, 2019

hi, @tombuildsstuff is there a timeline targeting this change?

@tombuildsstuff
Copy link
Owner Author

This looks fine with a fresh pair of eyes 👍

@tombuildsstuff tombuildsstuff merged commit 9bbc889 into master Sep 13, 2019
@tombuildsstuff tombuildsstuff deleted the f/datalakestorage-gen2-filesystem branch September 13, 2019 09:14
@tombuildsstuff tombuildsstuff restored the f/datalakestorage-gen2-filesystem branch September 13, 2019 09:14
@tombuildsstuff tombuildsstuff deleted the f/datalakestorage-gen2-filesystem branch September 13, 2019 09:14
@tombuildsstuff
Copy link
Owner Author

@tcz001 apologies for the delay - this has been released in v0.6.0 of this library

@tcz001 tcz001 mentioned this pull request Sep 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katbyte katbyte Awaiting requested review from katbyte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.

storage datalake support
2 participants
@tombuildsstuff @tcz001