Fix StdinDataRedirection's formulate() method #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The StdinDataRedirection command object was returning a list inside a
list, which caused trouble when getting the "str()" of the command.
Example:
Python 3.10.8 (tags/v3.10.8:aaaf517, Oct 11 2022, 16:50:30) [MSC v.1933 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> from plumbum.cmd import head
>>> cmd = head['-2'] << "one\ntwo\nthree\nfour"
>>> print(f"{cmd}")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\Python310\lib\site-packages\plumbum\commands\base.py", line 66, in __str__
return " ".join(self.formulate())
TypeError: sequence item 2: expected str instance, list found
>>>
henryiii
reviewed
Nov 1, 2023
Comment on lines
+539
to
+540
| "|" | ||
| ] + self.cmd.formulate(level + 1, args), |
There was a problem hiding this comment.
Suggested change
| "|" | |
| ] + self.cmd.formulate(level + 1, args), | |
| "|", | |
| *self.cmd.formulate(level + 1, args), | |
| ] |
henryiii
added a commit
that referenced
this pull request
Nov 1, 2023
Signed-off-by: Henry Schreiner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return flat list from derived object's formulate()
The StdinDataRedirection command object was returning a list inside a list, which caused trouble when getting the "str()" of the command.
Simple example to demonstrate the problem:
This addresses open issue #398