Skip to content

Commit

Permalink
Clean up and clarify e2e scripts (sigstore#3628)
Browse files Browse the repository at this point in the history
* Add comment to test/piv_test.go

Since f6d8481 it's not clear what this file is for, as it's not run in
CI. Add a link to the docs that reference it to make it clear this is
still needed.

Signed-off-by: Colleen Murphy <[email protected]>

* Clean up unused test script

e2e_test_secrets.sh is no longer called from CI as of f633221. It's
objective is largely redundant with tests already in e2e_test.go, so
just remove it.

Signed-off-by: Colleen Murphy <[email protected]>

---------

Signed-off-by: Colleen Murphy <[email protected]>
  • Loading branch information
cmurphy authored and tommyd450 committed Jun 7, 2024
1 parent 3300f2e commit f0b9826
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 175 deletions.
175 changes: 0 additions & 175 deletions test/e2e_test_secrets.sh

This file was deleted.

1 change: 1 addition & 0 deletions test/piv_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
// This test requires a yubikey to be present. It WILL reset the yubikey to exercise functionality.
// DO NOT RUN THIS TEST IF YOU DO NOT WANT TO RESET YOUR YUBIKEY
// This requires the "resetyubikey" tag to be passed to go test.
// See https://docs.sigstore.dev/key_management/hardware-based-tokens/#tested-devices

package test

Expand Down

0 comments on commit f0b9826

Please sign in to comment.