Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Test CI #15

Merged
merged 10 commits into from
Aug 8, 2024
Merged

Add Test CI #15

merged 10 commits into from
Aug 8, 2024

Conversation

yutannihilation
Copy link
Contributor

Close #7

Some notes:

  • Currently this fails because of the problem I reported in Fix fncall #14.
  • The config matrix contains only Ubuntu for now because no difference is found so far between platforms. But, it's easy to add macOS and Windows as well.
  • The setup for ALSA is derived from cpal's GitHub Actions settings.

@yutannihilation
Copy link
Contributor Author

You can see how this CI setup runs (and fails) here:

https://github.com/yutannihilation/mimium-rs/actions

@tomoyanonymous
Copy link
Owner

Thanks! This really helps.

In the config, both stable and nightly channels are tested but stable channel looks like being overwritten to nightly by rust-toolchain.toml

https://github.com/yutannihilation/mimium-rs/actions/runs/10293042761/job/28488605866#step:3:67

Run rustup default stable
info: using existing install for 'stable-x86_64-unknown-linux-gnu'
info: default toolchain set to 'stable-x86_64-unknown-linux-gnu'

  stable-x86_64-unknown-linux-gnu unchanged - rustc 1.80.0 (0514789[57](https://github.com/yutannihilation/mimium-rs/actions/runs/10293042761/job/28488605866#step:3:64) 2024-07-21)
info: note that the toolchain 'nightly-x86_64-unknown-linux-gnu' is currently in use (overridden by '/home/runner/work/mimium-rs/mimium-rs/rust-toolchain.toml')

I set nightly as a default because I use some unstable feature, especially box_pattern and iterator_try_collect to simplify the codes. So, I think we need to test only nightly toolchain for now.

box_pattern seems to hardly be stabilized, however, if we start using arena for recursive types(#12), box_pattern will no longer needed anyway.

rust-lang/rust#29641

@yutannihilation
Copy link
Contributor Author

Oh, I see. I forgot rust-toolchain.toml exists. Then I remove the stable case.

Thanks for explaining the context including #12. Since this project is mainly about providing a binary, not a library, I guess compatibility with stable is not very important. But, #12 looks nice. I'll try to understand.

@yutannihilation
Copy link
Contributor Author

result:
https://github.com/yutannihilation/mimium-rs/actions/runs/10295092683

(mainly note to self)
I quickly searched if there's some way to let dtolnay/rust-toolchain refer to rust-toolchain.toml instead of specifying toolchain: nightly, but it seems the author doesn't want to support it. So, probably there's no nicer way.

dtolnay/rust-toolchain#77

@tomoyanonymous tomoyanonymous merged commit ce9e4b8 into tomoyanonymous:dev Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants