-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firewall support #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution! There are some changes required. Please check the review.
src/main/java/me/tomsdevsn/hetznercloud/objects/general/FWApplicationTarget.java
Outdated
Show resolved
Hide resolved
It would be cool if you can add your change in // edit Okay I just saw that you are not on latest master. I'll approve the MR and add the changelog afterwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Again, Thank you for your contribution!
👍 |
I added firewall support as noted in #38, but mostly ignored tests