prevent okhttp post with null body #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okhttp doesn't let to send post requests with null body, and also the body (with empty json object) is required by hetzner cloud api.
tomsiewert
approved these changes
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okhttp doesn't let to send post requests with null body, and also the body (with empty json object) is required by hetzner cloud api.
Your latest changes (migrating to okhttp) broke our automation tool, all post requests with null body are broken right now, like reset-server request and so on...
Passing empty json object whenever the body is null did the trick cause it's required by both okhttp and hetzner cloud api.