Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Color picker out of view in Customizer #477

Merged
merged 5 commits into from
Nov 17, 2022

Conversation

tomusborne
Copy link
Owner

@tomusborne tomusborne commented Nov 16, 2022

close #476

__unstableShift has been removed from Gutenberg and will be removed from WordPress in 6.3: https://github.com/WordPress/gutenberg/blob/1a2f1ab6e1a2497a1cf0a77984d7ddf57a7da27c/packages/components/CHANGELOG.md#deprecations-2

Looks like it was actually completely removed in 6.1.1: WordPress/gutenberg#45195

This PR should be tested in:

  • WP 5.9.5
  • WP 6.0.3
  • WP 6.1.0
  • WP 6.1.1

@tomusborne tomusborne added the bug Bugs, unexpected and weird behaviors label Nov 16, 2022
@tomusborne tomusborne added this to the 3.3.0 milestone Nov 16, 2022
@tomusborne tomusborne linked an issue Nov 16, 2022 that may be closed by this pull request
@tomusborne tomusborne changed the base branch from release/3.3.0 to release/3.2.3 November 16, 2022 23:13
@tomusborne tomusborne modified the milestones: 3.3.0, 3.2.3 Nov 16, 2022
Copy link
Contributor

@JeanPaiva JeanPaiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in all 4 versions with both Firefox and Chrome.

From version 6.0 onwards Firefox has had an issue with the scrollbar on the top of the picker.

image

@tomusborne
Copy link
Owner Author

@JeanPaiva I can see the scrollbar for a second on MacOS, but it disappears. Checked on Windows using Chrome and Firefox and no issues there. Does the scrollbar stick around like your screenshot for you?

@tomusborne tomusborne merged commit 18498d8 into release/3.2.3 Nov 17, 2022
@tomusborne tomusborne deleted the fix-color-picker-shift branch November 17, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs, unexpected and weird behaviors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WP 6.1.1 - Color Picker modal falls off screen on MacOS ALL browsers
2 participants