Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying target version #46

Merged
merged 5 commits into from
Oct 25, 2017

Conversation

arvindsv
Copy link
Contributor

@arvindsv arvindsv commented Oct 25, 2017

Equivalent of tomzo/gocd-json-config-plugin#12 for the yaml plugin.

Does this:

  1. Updates README: Mostly Go => GoCD and *.go.cd to *.gocd.org.
  2. Accept multiple patterns in the settings file. Old (single) patterns work too.
  3. Allow specifying target version in the YAML.
  4. Accept lock_behavior in the YAML.

It'll be like this, for every file:

format_version: 2
environments:
  env1: ...
  env2: ...
pipelines:
  pipe1:
      lock_behavior: "lockOnFailure"
      ...

* Mostly Go => GoCD
* Update *.go.cd to *.gocd.org
* All files should have the same version in a repo.
* Missing versions are assumed to be the same as the default version, ie, 1.
@arvindsv
Copy link
Contributor Author

arvindsv commented Oct 25, 2017

@tomzo If you merge this, you can change the default format for #35.

As you know, you'll need to change it here and here to **/*.gocd.yaml, **/*.gocd.yml. If you want.

Oh, you'll also need to add a similar note about format_version in the README.

@arvindsv
Copy link
Contributor Author

arvindsv commented Oct 25, 2017

Just for the record, the corresponding PR in the GoCD codebase is gocd/gocd#3943.

@tomzo tomzo merged commit aa14da9 into tomzo:master Oct 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants