This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Updated to remove negative diff in time calculation #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of 'def diff = (int) (long)...' causes a negative value when difference is months (23 March to 06 May). No idea why. Changing to 'int diff = ...' removes this problem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Types of changes
Description of Changes
Use of 'def diff = (int) (long)...' causes a negative value when difference is months (23 March to 06 May). No idea why. Changing to 'int diff = ...' removes this problem
Reason for Change
Nest mode change is constantly skipped due to incorrect result from date diff.
How Has This Been Tested?
Tested via graph by adding extra logging and identifying the change of nest mode was constantly being skipped because of a negative value be generated by the difference calculation. The simple change proposed allows it to correctly return the difference.
Screenshots (if appropriate):