Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ add toasts #103

Merged
merged 20 commits into from
Dec 30, 2022
Merged

✨ add toasts #103

merged 20 commits into from
Dec 30, 2022

Conversation

AntoineKM
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Dec 24, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
kitchen-docs ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 30, 2022 at 4:31PM (UTC)
kitchen-next-typescript ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Dec 30, 2022 at 4:31PM (UTC)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2022 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
packages/kitchen/dist/tonightpass-kitchen.cjs.prod.js 268.44 KB (+0.52% 🔺) 5.4 s (+0.52% 🔺) 647 ms (-15.86% 🔽) 6.1 s
packages/kitchen/dist/tonightpass-kitchen.esm.js 89.91 KB (+1.56% 🔺) 1.8 s (+1.56% 🔺) 284 ms (-46.59% 🔽) 2.1 s
packages/kitchen/next/dist/tonightpass-kitchen-next.cjs.prod.js 26 KB (0%) 520 ms (0%) 191 ms (+6.86% 🔺) 711 ms
packages/kitchen/next/dist/tonightpass-kitchen-next.esm.js 25.18 KB (0%) 504 ms (0%) 124 ms (-28.6% 🔽) 628 ms
packages/kitchen/native/dist/tonightpass-kitchen-native.cjs.prod.js 28.07 KB (0%) 562 ms (0%) 151 ms (-35.31% 🔽) 712 ms
packages/kitchen/native/dist/tonightpass-kitchen-native.esm.js 27.84 KB (0%) 557 ms (0%) 218 ms (+39.61% 🔺) 775 ms

@AntoineKM AntoineKM changed the title Antoinekm/toast ✨ add toasts Dec 24, 2022
@AntoineKM AntoineKM linked an issue Dec 24, 2022 that may be closed by this pull request
Add Toast #35
Closed
@AntoineKM AntoineKM self-assigned this Dec 24, 2022
@AntoineKM AntoineKM added the enhancement New feature or request label Dec 24, 2022
@AntoineKM AntoineKM linked an issue Dec 24, 2022 that may be closed by this pull request
Add radius and gap props in the theme #56
Closed
@AntoineKM AntoineKM marked this pull request as ready for review December 29, 2022 13:59
jerembdn
jerembdn requested changes Dec 29, 2022
View reviewed changes
Copy link
Member

@jerembdn jerembdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Le CancelToast ne disparait pas du DOM quand on clique sur cancel

@AntoineKM AntoineKM merged commit 0fbe1e9 into develop Dec 30, 2022
@AntoineKM AntoineKM deleted the antoinekm/toast branch December 30, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounesBessa YounesBessa Awaiting requested review from YounesBessa

@jerembdn jerembdn Awaiting requested review from jerembdn

Assignees

@AntoineKM AntoineKM

Labels
enhancement New feature or request
Projects
Kitchen Plan
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add radius and gap props in the theme Add Toast
2 participants
@AntoineKM @jerembdn